Add ParparVM annotations to disable debug and safety checks for hot Base64 methods by liannacasper · Pull Request #4732 · codenameone/CodenameOne

liannacasper · 2026-04-10T14:34:15Z

Motivation

Provide a way to selectively disable ParparVM emitted debug info and runtime array/null checks for performance-sensitive methods.
Target hotspot Base64 encoding/decoding routines to measure the effect of disabling those checks.

Description

Add two method-level annotations: com.codename1.annotations.DisableDebugInfo and com.codename1.annotations.DisableNullChecksAndArrayBoundsChecks to mark methods for reduced ParparVM emission.
Wire the Parser to detect those annotations during method visit and set per-method flags on BytecodeMethod via setDisableDebugInfo and setDisableNullAndArrayBoundsChecks.
Honor the flags during code emission so LineNumber no longer emits __CN1_DEBUG_INFO(...) when debug info is disabled and array load/store code (and ArrayLoadExpression) skip CHECK_ARRAY_ACCESS(...) / CHECK_ARRAY_ACCESS_WITH_ARGS(...) when null/array-bounds checks are disabled.
Annotate hot Base64 methods (decode(byte[],int,byte[]), decodeNoWhitespace(...), encodeNoNewline(...)) with the new annotations and add translator unit tests asserting suppression of debug and array-check emissions.

Testing

Ran the ParparVM translator unit suite test BytecodeInstructionIntegrationTest with mvn -pl tests -am -Dtest=BytecodeInstructionIntegrationTest -Dsurefire.failIfNoSpecifiedTests=false test and it passed: 31 tests, 0 failures.
Tried mvn -pl tests -Dtest=BytecodeInstructionIntegrationTest test without reactor build flags and also tried invoking Maven with a Java 8 JAVA_HOME; those invocations initially failed due to environment-specific setup (missing JAVA_HOME path or missing module artifact), but the full translator test run above completed successfully.

Codex Task

github-actions · 2026-04-10T14:42:17Z

✅ Continuous Quality Report

Test & Coverage

✅ Tests: 2370 total, 0 failed, 0 skipped
📊 Line coverage: 53.34% [HTML preview] [Download]
- Lowest covered classes
  - com.codename1.ui.Display$EdtException – 0.00%
  - com.codename1.ui.plaf.CSSBorder$LinearGradient – 0.00%
  - com.codename1.util.EasyThread$InQueueRunnable – 0.00%
  - com.codename1.components.FloatingActionButton$ReleaseActionListener – 0.00%
  - com.codename1.io.Oauth2$ShowAuthenticationActionListener – 0.00%
  - com.codename1.io.Oauth2$RefreshTokenActionListener – 0.00%
  - com.codename1.util.EasyThread$RunAndWaitRunnable – 0.00%
  - com.codename1.components.ToastBar$FlushAnimationCallback – 0.00%
  - com.codename1.ui.plaf.CSSBorder$ColorStop – 0.00%
  - com.codename1.ui.ElevationComparator – 0.00%

Static Analysis

SpotBugs [HTML preview] [Download]
- ❌ ByteCodeTranslator: 110 findings (High: 2, Normal: 81, Low: 27)
  - Top findings
    - High: com/codename1/tools/translator/BytecodeMethod.java:647 – Method com.codename1.tools.translator.BytecodeMethod.findWritableFields(Set) seems to be useless (rule: UC_USELESS_VOID_METHOD)
    - High: com/codename1/tools/translator/bytecodes/TryCatch.java:91 – Write to static field com.codename1.tools.translator.bytecodes.TryCatch.hasTryCatch from instance method com.codename1.tools.translator.bytecodes.TryCatch.appendInstruction(StringBuilder, List) (rule: ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD)
    - Normal: com/codename1/tools/translator/ByteCodeClass.java:1802 – com.codename1.tools.translator.ByteCodeClass.getBaseClassObject() may expose internal representation by returning ByteCodeClass.baseClassObject (rule: EI_EXPOSE_REP)
    - …and 107 more
- ❌ android: 414 findings (High: 24, Normal: 196, Low: 194)
  - Top findings
    - High: CodenameOne/src/com/codename1/impl/CodenameOneThread.java:48 – com.codename1.impl.CodenameOneThread.STACK_FRAME_SIZE isn't final but should be (rule: MS_SHOULD_BE_FINAL)
    - High: com/codename1/impl/android/AndroidImplementation.java:1085 – Write to static field com.codename1.impl.android.AndroidImplementation.context from instance method com.codename1.impl.android.AndroidImplementation.setContext(Context) (rule: ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD)
    - High: com/codename1/impl/android/AndroidImplementation.java:1286 – com.codename1.impl.android.AndroidImplementation.isDarkMode() has Boolean return type and returns explicit null (rule: NP_BOOLEAN_RETURN_NULL)
    - …and 411 more
- ❌ codenameone-maven-plugin: 496 findings (High: 1, Normal: 319, Low: 176)
  - Top findings
    - High: com/codename1/maven/AbstractCN1Mojo.java:807 – com.codename1.maven.AbstractCN1Mojo.OS isn't final but should be (rule: MS_SHOULD_BE_FINAL)
    - Normal: com/codename1/builders/AndroidGradleBuilder.java:1020 – Dead store to googleServicesJson in com.codename1.builders.AndroidGradleBuilder.build(File, BuildRequest) (rule: DLS_DEAD_LOCAL_STORE)
    - Normal: com/codename1/builders/AndroidGradleBuilder.java:1045 – Possible null pointer dereference in com.codename1.builders.AndroidGradleBuilder.build(File, BuildRequest) due to return value of called method (rule: NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE)
    - …and 493 more
- ❌ core-unittests: 1 findings (Normal: 1)
  - Top findings
    - Normal: CodenameOne/src/com/codename1/ui/util/MutableResource.java:239 – com.codename1.ui.util.MutableResource.saveL10N(DataOutputStream, Hashtable) makes inefficient use of keySet iterator instead of entrySet iterator (rule: WMI_WRONG_MAP_ITERATOR)
- ❌ ios: 125 findings (High: 4, Normal: 75, Low: 46)
  - Top findings
    - High: com/codename1/impl/ios/IOSImplementation.java:1228 – com.codename1.impl.ios.IOSImplementation.isDarkMode() has Boolean return type and returns explicit null (rule: NP_BOOLEAN_RETURN_NULL)
    - High: com/codename1/impl/ios/IOSImplementation.java:128 – com.codename1.impl.ios.IOSImplementation.nativeInstance isn't final but should be (rule: MS_SHOULD_BE_FINAL)
    - High: com/codename1/impl/ios/IOSImplementation.java:214 – Write to static field com.codename1.impl.ios.IOSImplementation.instance from instance method com.codename1.impl.ios.IOSImplementation.init(Object) (rule: ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD)
    - …and 122 more
✅ PMD: 0 findings (no issues) [Report archive]
✅ Checkstyle: 0 findings (no issues) [Report archive]

Generated automatically by the PR CI workflow.

shai-almog · 2026-04-10T14:48:53Z

Android screenshot updates

Compared 36 screenshots: 35 matched, 1 updated.

ValidatorLightweightPicker — updated screenshot. Screenshot differs (320x640 px, bit depth 8).

Preview info: JPEG preview quality 70; JPEG preview quality 70.
Full-resolution PNG saved as ValidatorLightweightPicker.png in workflow artifacts.

Native Android coverage

📊 Line coverage: 7.79% (4094/52579 lines covered) [HTML preview] (artifact android-coverage-report, jacocoAndroidReport/html/index.html)
- Other counters: instruction 6.10% (20207/331490), branch 2.93% (937/31974), complexity 3.63% (1113/30622), method 6.37% (911/14300), class 10.50% (199/1896)
- Lowest covered classes
  - kotlin.collections.kotlin.collections.ArraysKt___ArraysKt – 0.00% (0/6327 lines covered)
  - kotlin.collections.unsigned.kotlin.collections.unsigned.UArraysKt___UArraysKt – 0.00% (0/2384 lines covered)
  - org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.ClassReader – 0.00% (0/1519 lines covered)
  - kotlin.collections.kotlin.collections.CollectionsKt___CollectionsKt – 0.00% (0/1148 lines covered)
  - org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.MethodWriter – 0.00% (0/923 lines covered)
  - kotlin.sequences.kotlin.sequences.SequencesKt___SequencesKt – 0.00% (0/730 lines covered)
  - kotlin.text.kotlin.text.StringsKt___StringsKt – 0.00% (0/623 lines covered)
  - org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.Frame – 0.00% (0/564 lines covered)
  - kotlin.collections.kotlin.collections.ArraysKt___ArraysJvmKt – 0.00% (0/495 lines covered)
  - kotlinx.coroutines.kotlinx.coroutines.JobSupport – 0.00% (0/423 lines covered)

Benchmark Results

Detailed Performance Metrics

Metric	Duration
Base64 payload size	8192 bytes
Base64 benchmark iterations	6000
Base64 native encode	920.000 ms
Base64 CN1 encode	125.000 ms
Base64 encode ratio (CN1/native)	0.136x (86.4% faster)
Base64 native decode	859.000 ms
Base64 CN1 decode	194.000 ms
Base64 decode ratio (CN1/native)	0.226x (77.4% faster)

github-actions · 2026-04-10T15:07:00Z

✅ ByteCodeTranslator Quality Report

Test & Coverage

✅ Tests: 381 total, 0 failed, 2 skipped

Benchmark Results

Execution Time: 10507 ms
Hotspots (Top 20 sampled methods):
- 23.62% java.lang.String.indexOf (442 samples)
- 17.96% com.codename1.tools.translator.Parser.isMethodUsed (336 samples)
- 13.68% java.util.ArrayList.indexOf (256 samples)
- 6.41% com.codename1.tools.translator.Parser.addToConstantPool (120 samples)
- 4.28% java.lang.Object.hashCode (80 samples)
- 4.12% com.codename1.tools.translator.ByteCodeClass.markDependent (77 samples)
- 2.99% java.lang.System.identityHashCode (56 samples)
- 1.66% com.codename1.tools.translator.Parser.generateClassAndMethodIndexHeader (31 samples)
- 1.60% com.codename1.tools.translator.BytecodeMethod.equals (30 samples)
- 1.39% com.codename1.tools.translator.BytecodeMethod.optimize (26 samples)
- 1.23% com.codename1.tools.translator.ByteCodeClass.calcUsedByNative (23 samples)
- 1.18% com.codename1.tools.translator.Parser.getClassByName (22 samples)
- 1.18% java.lang.StringCoding.encode (22 samples)
- 1.07% java.lang.StringBuilder.append (20 samples)
- 1.02% com.codename1.tools.translator.ByteCodeClass.fillVirtualMethodTable (19 samples)
- 0.75% com.codename1.tools.translator.BytecodeMethod.appendCMethodPrefix (14 samples)
- 0.75% sun.nio.fs.UnixNativeDispatcher.open0 (14 samples)
- 0.69% com.codename1.tools.translator.Parser.cullMethods (13 samples)
- 0.69% java.util.ArrayList$Itr.next (13 samples)
- 0.59% com.codename1.tools.translator.BytecodeMethod.addToConstantPool (11 samples)
⚠️ Coverage report not generated.

Static Analysis

✅ SpotBugs: no findings (report was not generated by the build).
⚠️ PMD report not generated.
⚠️ Checkstyle report not generated.

Generated automatically by the PR CI workflow.

shai-almog · 2026-04-10T15:08:12Z

Compared 36 screenshots: 36 matched.
✅ Native iOS screenshot tests passed.

Benchmark Results

VM Translation Time: 0 seconds
Compilation Time: 93 seconds

Detailed Performance Metrics

Metric	Duration
Simulator Boot	0 ms
Simulator Boot (Run)	0 ms
App Install	2000 ms
App Launch	6000 ms
Test Execution	146000 ms
Base64 payload size	8192 bytes
Base64 benchmark iterations	6000
Base64 native encode	899.000 ms
Base64 CN1 encode	1176.000 ms
Base64 encode ratio (CN1/native)	1.308x (30.8% slower)
Base64 native decode	684.000 ms
Base64 CN1 decode	942.000 ms
Base64 decode ratio (CN1/native)	1.377x (37.7% slower)

github-actions · 2026-04-11T12:36:23Z

Developer Guide build artifacts are available for download from this workflow run:

Developer Guide quality checks:

AsciiDoc linter: 1 issue(s) flagged (1 errors) (exit code 1) (report)
Vale: 18621 alert(s) (2704 errors, 6359 warnings, 9558 suggestions) (exit code 1) (report)
Image references: 33 unused image(s) found (report)

Unused image preview:

img/uwp-app-manager-apps.png
img/uwp-certificate-generator.png
img/uwp-cn1settings-debug-desktop-selected.png
img/uwp-cn1settings-disk-icon.png
img/uwp-cn1settings-uwp.png
img/uwp-cn1settings-windows-settings-menu-item.png
img/uwp-dashboard-download-appxbundle.png
img/uwp-extract-zip-file.png
img/uwp-mobile-recently-added.png
img/uwp-mobile-settings-developer-mode.png
... and 23 more

Add ParparVM method annotations to disable debug and safety checks

d5d3c3f

liannacasper added the codex label Apr 10, 2026 — with ChatGPT Codex Connector

liannacasper added 13 commits April 10, 2026 18:54

Optimize debug-disabled methods by skipping local debug metadata

726a0b6

Add fast method stack path and static init call fast-check

5d78893

Fix static initializer fast-path guard to use class initialized flag

9145cc1

Add primitive fast-frame path and inline fast return release

1ca030a

Add missing exception constructor declarations for fast stack init

ec97029

Revert Base64 annotation opt-in after no benchmark gain

ace255d

Refine fast primitive frame init to avoid slow per-slot loop

90c6f1c

Restore Base64 annotation-based translator optimizations

850df0f

Optimize Base64 decode map lookups for CN1 runtime

c9b9765

Tighten Base64 decode locals to aid C optimizer

1149946

Harden Base64 fast decode writes with explicit bounds guards

ea4c1b8

Revert decode-local tweaks and enforce Release builds in perf tests

8a26354

Document ParparVM performance hints and tradeoffs in developer guide

1f8b029

liannacasper merged commit 22eb74f into master Apr 11, 2026
20 of 22 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add ParparVM annotations to disable debug and safety checks for hot Base64 methods#4732

Add ParparVM annotations to disable debug and safety checks for hot Base64 methods#4732
liannacasper merged 14 commits intomasterfrom
codex/add-annotations-to-disable-parparvm-checks

liannacasper commented Apr 10, 2026

Uh oh!

github-actions Bot commented Apr 10, 2026 •

edited

Loading

Uh oh!

shai-almog commented Apr 10, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Apr 10, 2026 •

edited

Loading

Uh oh!

shai-almog commented Apr 10, 2026 •

edited

Loading

Uh oh!

Uh oh!

github-actions Bot commented Apr 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

liannacasper commented Apr 10, 2026

Motivation

Description

Testing

Uh oh!

github-actions Bot commented Apr 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Continuous Quality Report

Test & Coverage

Static Analysis

Uh oh!

shai-almog commented Apr 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Android screenshot updates

Native Android coverage

Benchmark Results

Detailed Performance Metrics

Uh oh!

github-actions Bot commented Apr 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ ByteCodeTranslator Quality Report

Test & Coverage

Benchmark Results

Static Analysis

Uh oh!

shai-almog commented Apr 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmark Results

Detailed Performance Metrics

Uh oh!

Uh oh!

github-actions Bot commented Apr 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions Bot commented Apr 10, 2026 •

edited

Loading

shai-almog commented Apr 10, 2026 •

edited

Loading

github-actions Bot commented Apr 10, 2026 •

edited

Loading

shai-almog commented Apr 10, 2026 •

edited

Loading